[llvm] [GlobalMerge] Use constructor to set all bits in BitVector. NFC (PR #124375)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 16:41:06 PST 2025


https://github.com/topperc created https://github.com/llvm/llvm-project/pull/124375

The constructor has an optional bool for the starting value for each bit. Use that instead of calling set().

>From df1946cb967a342fe827a81bca44bf0529a9f1bf Mon Sep 17 00:00:00 2001
From: Craig Topper <craig.topper at sifive.com>
Date: Fri, 24 Jan 2025 16:38:49 -0800
Subject: [PATCH] [GlobalMerge] Use constructor to set all bits in BitVector.
 NFC

The constructor has an optional bool for the starting value for
each bit. Use that instead of calling set().
---
 llvm/lib/CodeGen/GlobalMerge.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/llvm/lib/CodeGen/GlobalMerge.cpp b/llvm/lib/CodeGen/GlobalMerge.cpp
index 41e01a1d3ccd52..8c18dda67438ae 100644
--- a/llvm/lib/CodeGen/GlobalMerge.cpp
+++ b/llvm/lib/CodeGen/GlobalMerge.cpp
@@ -271,8 +271,7 @@ bool GlobalMergeImpl::doMerge(SmallVectorImpl<GlobalVariable *> &Globals,
 
   // If we want to just blindly group all globals together, do so.
   if (!GlobalMergeGroupByUse || (Opt.MergeConstAggressive && isConst)) {
-    BitVector AllGlobals(Globals.size());
-    AllGlobals.set();
+    BitVector AllGlobals(Globals.size(), true);
     return doMerge(Globals, AllGlobals, M, isConst, AddrSpace);
   }
 



More information about the llvm-commits mailing list