[compiler-rt] [TSan][Apple] Fix interceptor build error (PR #124351)

Julian Lettner via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 15:04:45 PST 2025


================
@@ -111,6 +109,7 @@ OSATOMIC_INTERCEPTORS_BITWISE(OSAtomicAnd, fetch_and,
                               OSATOMIC_INTERCEPTOR_PLUS_X, OSATOMIC_INTERCEPTOR)
 OSATOMIC_INTERCEPTORS_BITWISE(OSAtomicXor, fetch_xor,
                               OSATOMIC_INTERCEPTOR_PLUS_X, OSATOMIC_INTERCEPTOR)
+#  pragma clang diagnostic pop  // OSAtomic* deprecation
----------------
yln wrote:

Missing `pop` here deactivated deprecation checking for the rest of the file.  @cachemeifyoucan 
I added it and fixed the remaining warnings.

Alternatively, we could just put the `# pragma clang diagnostic ignored "-Wdeprecated-declarations"` at the start of the file to intentionally disable deprecation warnings for the entire file and relief ourselves from some tedium.
@vitalybuka, any style preferences?

https://github.com/llvm/llvm-project/pull/124351


More information about the llvm-commits mailing list