[lld] [lld/COFF] Fix -start-lib / -end-lib more after reviews.llvm.org/D116434 (PR #124294)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 09:35:59 PST 2025


================
@@ -56,6 +56,8 @@ static void forceLazy(Symbol *s) {
   }
   case Symbol::Kind::LazyObjectKind: {
     InputFile *file = cast<LazyObject>(s)->file;
+    if (!file->lazy)
----------------
MaskRay wrote:

The test is good but this looks like a band aid, which will be unneeded when COFF resolves defined before undefined.

Related, lld/ELF/Symbols.cpp Symbol::extract has an unneeded `file->lazy` check, which I am removing now.

https://github.com/llvm/llvm-project/pull/124294


More information about the llvm-commits mailing list