[flang] [llvm] [Flang][OpenMP] Add global address space to globals for target device (PR #119585)

Sergio Afonso via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 04:34:47 PST 2025


================
@@ -134,16 +134,65 @@ addLLVMOpBundleAttrs(mlir::ConversionPatternRewriter &rewriter,
 }
 
 namespace {
+
+// Creates an existing operation with an AddressOfOp or an AddrSpaceCastOp
+// depending on the existing address spaces of the type.
+mlir::Value createAddrOfOrASCast(mlir::ConversionPatternRewriter &rewriter,
+                                 mlir::Location loc, std::uint64_t globalAS,
+                                 std::uint64_t programAS,
+                                 llvm::StringRef symName, mlir::Type type) {
+  if (mlir::isa<mlir::LLVM::LLVMPointerType>(type)) {
+    if (globalAS != programAS) {
+      auto llvmAddrOp = rewriter.create<mlir::LLVM::AddressOfOp>(
+          loc, getLlvmPtrType(rewriter.getContext(), globalAS), symName);
+      return rewriter.create<mlir::LLVM::AddrSpaceCastOp>(
+          loc, getLlvmPtrType(rewriter.getContext(), programAS), llvmAddrOp);
+    }
+    return rewriter.create<mlir::LLVM::AddressOfOp>(
+        loc, getLlvmPtrType(rewriter.getContext(), globalAS), symName);
----------------
skatrak wrote:

```suggestion
    auto llvmAddrOp = rewriter.create<mlir::LLVM::AddressOfOp>(
        loc, getLlvmPtrType(rewriter.getContext(), globalAS), symName);
    if (globalAS != programAS)
      return rewriter.create<mlir::LLVM::AddrSpaceCastOp>(
          loc, getLlvmPtrType(rewriter.getContext(), programAS), llvmAddrOp);
    return llvmAddrOp;
```

https://github.com/llvm/llvm-project/pull/119585


More information about the llvm-commits mailing list