https://github.com/cjappl requested changes to this pull request. Just "requesting changes" so we can discuss my top level comment, code looks great but please don't submit until we come to an agreement there. https://github.com/llvm/llvm-project/pull/124194