[llvm] [ConstantMerge] Only merge constant w/unnamed_addr (PR #124050)

[Eli Friedman via llvm-commits]

efriedma-quic wrote:

> though I feel like I saw a longer discussion on this somewhere else...

I don't recall anything else.  At least not for that particular aspect of it; there's discussion elsewhere about LTO making unnamed_addr constants not have a unique address, but that's only loosely related.

> I don't think your actual problem is really related though

I agree.  There isn't any direct connection between the linkage of a global, and whether it's unnamed_addr.  Maybe constant merging needs a check to ensure it doesn't change the linkage of globals used by a pointer subtraction?

https://github.com/llvm/llvm-project/pull/124050