[llvm] [LoopPeel] Peel to make Phis loop inductions (PR #121104)

Jamie Schmeiser via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 12:35:21 PST 2025


jamieschmeiser wrote:

My only comments are stylistic.  The reason I added the PhiAnalyzer and brought the code into the class when I reworked/expanded the algorithms was that it organized things and cleaned up the calling between the various functions.  In that spirit, I would suggest adding ScalarEvolution as a member to PhiAnalyzer and setting it in the constructor rather than passing it around.  This is a minor stylistic nit but (I think) it makes the code cleaner and more readable.  I certainly wouldn't block this change for that if you do not agree.  Thanks for doing this.

https://github.com/llvm/llvm-project/pull/121104


More information about the llvm-commits mailing list