[llvm] [bazel] Remove DebugInfo files covered by more specific targets (PR #124138)
Jordan Rupprecht via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 23 09:17:48 PST 2025
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/124138
>From 66c66eab605028c7def74299b1fdaf02f06485b3 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht <rupprecht at google.com>
Date: Thu, 23 Jan 2025 08:03:30 -0800
Subject: [PATCH 1/3] [bazel] Remove DebugInfo files covered by more specific
DebugInfo targets
For example, `include/llvm/DebugInfo/DWARF/DWARFContext.h` is included as part of both the generic "DebugInfo" target as well as the specific "DebugInfoDWARF" target. It should only be in one. Tooling that manages build dependencies should be more accurate now.
---
utils/bazel/llvm-project-overlay/llvm/BUILD.bazel | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
index 56dff6b3ad5003..db7502922295ee 100644
--- a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -424,9 +424,8 @@ cc_library(
cc_library(
name = "DebugInfo",
- hdrs = glob(["include/llvm/DebugInfo/**/*.h"]),
+ hdrs = glob(["include/llvm/DebugInfo/*.h"]),
copts = llvm_copts,
- textual_hdrs = glob(["include/llvm/DebugInfo/**/*.def"]),
deps = [
":Object",
":Support",
>From 1169cd06161130fa450d5efaf0eac9dbac638f9a Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht <rupprecht at google.com>
Date: Thu, 23 Jan 2025 08:57:58 -0800
Subject: [PATCH 2/3] Add newly-needed BTF dep
---
utils/bazel/llvm-project-overlay/llvm/BUILD.bazel | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
index db7502922295ee..4a358c3b543858 100644
--- a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -606,6 +606,7 @@ cc_library(
deps = [
":BinaryFormat",
":DebugInfo",
+ ":DebugInfoBTF",
":DebugInfoDWARF",
":DebugInfoPDB",
":Demangle",
@@ -648,14 +649,14 @@ cc_binary(
"utils/TableGen/Basic/Attributes.cpp",
"utils/TableGen/Basic/CodeGenIntrinsics.cpp",
"utils/TableGen/Basic/CodeGenIntrinsics.h",
- "utils/TableGen/Basic/SDNodeProperties.cpp",
- "utils/TableGen/Basic/SDNodeProperties.h",
- "utils/TableGen/Basic/TableGen.h",
- "utils/TableGen/Basic/TableGen.cpp",
- "utils/TableGen/Basic/SequenceToOffsetTable.h",
"utils/TableGen/Basic/DirectiveEmitter.cpp",
"utils/TableGen/Basic/IntrinsicEmitter.cpp",
"utils/TableGen/Basic/RISCVTargetDefEmitter.cpp",
+ "utils/TableGen/Basic/SDNodeProperties.cpp",
+ "utils/TableGen/Basic/SDNodeProperties.h",
+ "utils/TableGen/Basic/SequenceToOffsetTable.h",
+ "utils/TableGen/Basic/TableGen.cpp",
+ "utils/TableGen/Basic/TableGen.h",
"utils/TableGen/Basic/VTEmitter.cpp",
"utils/TableGen/llvm-min-tblgen.cpp",
],
>From c66af7963ff805d952ddb8287f6b7a53ca195a0a Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht <rupprecht at google.com>
Date: Thu, 23 Jan 2025 09:17:10 -0800
Subject: [PATCH 3/3] Two more newly-needed deps
---
utils/bazel/llvm-project-overlay/llvm/BUILD.bazel | 2 ++
1 file changed, 2 insertions(+)
diff --git a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
index 4a358c3b543858..15bf750c47a673 100644
--- a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -3013,6 +3013,7 @@ cc_library(
deps = [
":BinaryFormat",
":DebugInfo",
+ ":DebugInfoDWARF",
":JITLink",
":OrcJIT",
":OrcShared",
@@ -4499,6 +4500,7 @@ cc_library(
":BinaryFormat",
":CodeGen",
":DebugInfo",
+ ":DebugInfoBTF",
":DebugInfoDWARF",
":Debuginfod",
":Demangle",
More information about the llvm-commits
mailing list