[llvm] [GlobalMerge][NFC] Skip sorting by profitability when it is not needed (PR #124146)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 23 09:03:14 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff bda39a6067833c9353adbc42bddb1b5808bcf44b 0bbe4bad5c364c1d7fbf3bdb9ebb7fcb88cb470b --extensions cpp -- llvm/lib/CodeGen/GlobalMerge.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/CodeGen/GlobalMerge.cpp b/llvm/lib/CodeGen/GlobalMerge.cpp
index 40e56a66c2..e137322459 100644
--- a/llvm/lib/CodeGen/GlobalMerge.cpp
+++ b/llvm/lib/CodeGen/GlobalMerge.cpp
@@ -438,7 +438,7 @@ bool GlobalMergeImpl::doMerge(SmallVectorImpl<GlobalVariable *> &Globals,
}
// Now we found a bunch of sets of globals used together. We accumulated
- // the number of times we encountered the sets (i.e., the number of functions
+ // the number of times we encountered the sets (i.e., the number of functions
// that use that exact set of globals). Multiply that by the size of the set
// to give us a crude profitability metric.
llvm::stable_sort(UsedGlobalSets,
``````````
</details>
https://github.com/llvm/llvm-project/pull/124146
More information about the llvm-commits
mailing list