[llvm] d8eb4ac - [Support] Remove ciso646 include (#123578)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 05:35:34 PST 2025


Author: Nikita Popov
Date: 2025-01-23T14:35:32+01:00
New Revision: d8eb4ac41d881a19bea7673d753ba92e6a11f5d6

URL: https://github.com/llvm/llvm-project/commit/d8eb4ac41d881a19bea7673d753ba92e6a11f5d6
DIFF: https://github.com/llvm/llvm-project/commit/d8eb4ac41d881a19bea7673d753ba92e6a11f5d6.diff

LOG: [Support] Remove ciso646 include (#123578)

This header has been removed in C++20 and causes a large amount of
deprecation spam when building against libstdc++ 15 in C++17 mode.

As far as I understand, we just need to include *some* STL header to get
access to the version macros, and as this header also includes
<optional> nowadays we can just drop the <cstd646> include entirely.

Added: 
    

Modified: 
    llvm/include/llvm/Support/Threading.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/Threading.h b/llvm/include/llvm/Support/Threading.h
index d8e2cb0514ddd7..01e26ad9b858ea 100644
--- a/llvm/include/llvm/Support/Threading.h
+++ b/llvm/include/llvm/Support/Threading.h
@@ -18,7 +18,6 @@
 #include "llvm/ADT/StringRef.h"
 #include "llvm/Config/llvm-config.h" // for LLVM_ON_UNIX
 #include "llvm/Support/Compiler.h"
-#include <ciso646> // So we can check the C++ standard lib macros.
 #include <optional>
 
 #if defined(_MSC_VER)


        


More information about the llvm-commits mailing list