[llvm] [X86] Fix invalid instructions on x32 with large stack frames (PR #124041)
Phoebe Wang via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 23 01:57:27 PST 2025
phoebewang wrote:
> @phoebewang Thanks for all your help reviewing this!
>
> For the code I split out (which emits a trap for impossibly large stack frames rather than using invalid instructions like `movl $4799999880, %ecx`), do you think it's worth submitting that as a new PR? I don't have any strong feelings about that change -- if you think it's a worthwhile improvement, I'm happy to write it up, or I can skip it if you don't think it's worth worrying about. Let me know what you'd prefer!
Yeah, please. I think it's more friendly for user to get obvious error than some mysterious result.
https://github.com/llvm/llvm-project/pull/124041
More information about the llvm-commits
mailing list