[llvm] 7575072 - [llvm-exegesis] Disable exhaustive tests on Windows
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 22 20:08:40 PST 2025
Author: Aiden Grossman
Date: 2025-01-23T04:08:31Z
New Revision: 75750722737e9128500b81363ba66c62fea1e4fe
URL: https://github.com/llvm/llvm-project/commit/75750722737e9128500b81363ba66c62fea1e4fe
DIFF: https://github.com/llvm/llvm-project/commit/75750722737e9128500b81363ba66c62fea1e4fe.diff
LOG: [llvm-exegesis] Disable exhaustive tests on Windows
When looking at the slowest lit tests, I'm seeing these four tests take
two to eight minutes. Test coverage on Linux should be sufficient for
the functionality on top of it not really being useful on Windows at
all.
This was observed when hacking on the new premerge in a windows VM.
Added:
Modified:
llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets-exhaustively.s
llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets.s
llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets-exhaustively.s
llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets.s
Removed:
################################################################################
diff --git a/llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets-exhaustively.s b/llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets-exhaustively.s
index 1e9c5c34115bbe..2e982f47835eca 100644
--- a/llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets-exhaustively.s
+++ b/llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets-exhaustively.s
@@ -1,3 +1,8 @@
+# Only run this on Linux. Running on Windows can take an exorbinant amount of
+# time (upwards of ten minutes), and the only place where this functionality is
+# really useful is Linux.
+# REQUIRES: x86_64-linux
+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=inverse_throughput -opcode-index=-1 --max-configs-per-opcode=1048576 --benchmark-phase=prepare-snippet --benchmarks-file=-
# FIXME: it would be good to check how many snippets we end up producing,
# but the number is unstable, so for now just check that we do not crash.
diff --git a/llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets.s b/llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets.s
index 538555ed809c08..084025acd49819 100644
--- a/llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets.s
+++ b/llvm/test/tools/llvm-exegesis/X86/inverse_throughput/inverse_throughput-prepare-all-snippets.s
@@ -1,3 +1,8 @@
+# Only run this on Linux. Running on Windows can take an exorbinant amount of
+# time (upwards of ten minutes), and the only place where this functionality is
+# really useful is Linux.
+# REQUIRES: x86_64-linux
+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=inverse_throughput -opcode-index=-1 --max-configs-per-opcode=1 --benchmark-phase=prepare-snippet --benchmarks-file=-
# FIXME: it would be good to check how many snippets we end up producing,
# but the number is unstable, so for now just check that we do not crash.
diff --git a/llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets-exhaustively.s b/llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets-exhaustively.s
index eeecd2e8196f46..bb9af9abbc09a2 100644
--- a/llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets-exhaustively.s
+++ b/llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets-exhaustively.s
@@ -1,3 +1,8 @@
+# Only run this on Linux. Running on Windows can take an exorbinant amount of
+# time (upwards of ten minutes), and the only place where this functionality is
+# really useful is Linux.
+# REQUIRES: x86_64-linux
+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=uops -opcode-index=-1 --max-configs-per-opcode=1048576 --benchmark-phase=prepare-snippet --benchmarks-file=-
# FIXME: it would be good to check how many snippets we end up producing,
# but the number is unstable, so for now just check that we do not crash.
diff --git a/llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets.s b/llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets.s
index d0a54e2476b166..d8ce870be1d60d 100644
--- a/llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets.s
+++ b/llvm/test/tools/llvm-exegesis/X86/uops/uops-prepare-all-snippets.s
@@ -1,3 +1,8 @@
+# Only run this on Linux. Running on Windows can take an exorbinant amount of
+# time (upwards of ten minutes), and the only place where this functionality is
+# really useful is Linux.
+# REQUIRES: x86_64-linux
+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=uops -opcode-index=-1 --max-configs-per-opcode=1 --benchmark-phase=prepare-snippet --benchmarks-file=-
# FIXME: it would be good to check how many snippets we end up producing,
# but the number is unstable, so for now just check that we do not crash.
More information about the llvm-commits
mailing list