[llvm] [openmp] [polly] GitHub Actions: Lint Python code for just for SyntaxErrors (PR #123940)
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 22 12:47:35 PST 2025
https://github.com/boomanaiden154 commented:
I'm not really sure this is something that we want. The vast majority of python files will be run (and thus checked for syntax) during pre and post commit testing, so this action would be redundant for those. Standalone scripts I'm not sure benefit much from being automatically checked.
The couple scripts that you have fixed here seem old enough/unused enough/untested enough that we might just want to remove them, although that would need to go through review with the maintainers of those projects.
Additionally, anything at the scale of the LLVM monorepo is hard to get right. Actions like this typically need to run on a diff rather than the entire repo due to time constraints and to prevent noise from other parts of the repo being broken. There are also often a lot of subtleties that are hard to get right. It took us a lot of effort to even just get our code formatting action nailed down to really high reliability due to several obscure issues.
https://github.com/llvm/llvm-project/pull/123940
More information about the llvm-commits
mailing list