[llvm] [GISel] Add more FP opcodes to CSE (PR #123624)

Wed Jan 22 06:38:56 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/11429

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[847/1371] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/TestAsmPrinter.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[848/1371] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/MachineBasicBlockTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[849/1371] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/MachineOperandTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[850/1371] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/DIETest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[851/1371] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o
FAILED: unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-pmxck88t/unittests/CodeGen/GlobalISel -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel -I/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-pmxck88t/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/third-party/unittest/googletest/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffat-lto-objects -no-canonical-prefixes -O3 -DNDEBUG -std=c++17 -fvisibility=default  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wno-suggest-override -MD -MT unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o -MF unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o.d -o unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o -c /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:84:14: error: no member named 'setFlag' in 'llvm::MachineInstrBuilder'; did you mean 'setMIFlag'?
   84 |     MIBFAdd2.setFlag(MachineInstr::FmNsz);
      |              ^~~~~~~
      |              setMIFlag
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include/llvm/CodeGen/MachineInstrBuilder.h:280:30: note: 'setMIFlag' declared here
  280 |   const MachineInstrBuilder &setMIFlag(MachineInstr::MIFlag Flag) const {
      |                              ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:87:13: error: no member named 'clearFlag' in 'llvm::MachineInstrBuilder'; did you mean to use '->' instead of '.'?
   87 |     MIBFAdd2.clearFlag(MachineInstr::FmNsz);
      |             ^
      |             ->
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:97:14: error: no member named 'setFlag' in 'llvm::MachineInstrBuilder'; did you mean 'setMIFlag'?
   97 |     MIBFSub2.setFlag(MachineInstr::FmNoNans);
      |              ^~~~~~~
      |              setMIFlag
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include/llvm/CodeGen/MachineInstrBuilder.h:280:30: note: 'setMIFlag' declared here
  280 |   const MachineInstrBuilder &setMIFlag(MachineInstr::MIFlag Flag) const {
      |                              ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:100:13: error: no member named 'clearFlag' in 'llvm::MachineInstrBuilder'; did you mean to use '->' instead of '.'?
  100 |     MIBFSub2.clearFlag(MachineInstr::FmNoNans);
      |             ^
      |             ->
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:110:14: error: no member named 'setFlag' in 'llvm::MachineInstrBuilder'; did you mean 'setMIFlag'?
  110 |     MIBFMul2.setFlag(MachineInstr::FmNoNans);
      |              ^~~~~~~
      |              setMIFlag
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include/llvm/CodeGen/MachineInstrBuilder.h:280:30: note: 'setMIFlag' declared here
  280 |   const MachineInstrBuilder &setMIFlag(MachineInstr::MIFlag Flag) const {
      |                              ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:113:13: error: no member named 'clearFlag' in 'llvm::MachineInstrBuilder'; did you mean to use '->' instead of '.'?
  113 |     MIBFMul2.clearFlag(MachineInstr::FmNoNans);
      |             ^
      |             ->
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:123:14: error: no member named 'setFlag' in 'llvm::MachineInstrBuilder'; did you mean 'setMIFlag'?
  123 |     MIBFDiv2.setFlag(MachineInstr::FmNoNans);
      |              ^~~~~~~
Step 7 (check) failure: check (failure)
...
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[847/1371] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/TestAsmPrinter.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[848/1371] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/MachineBasicBlockTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[849/1371] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/MachineOperandTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[850/1371] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/DIETest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[851/1371] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o
FAILED: unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-pmxck88t/unittests/CodeGen/GlobalISel -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel -I/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-pmxck88t/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/third-party/unittest/googletest/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffat-lto-objects -no-canonical-prefixes -O3 -DNDEBUG -std=c++17 -fvisibility=default  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wno-suggest-override -MD -MT unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o -MF unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o.d -o unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CSETest.cpp.o -c /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:84:14: error: no member named 'setFlag' in 'llvm::MachineInstrBuilder'; did you mean 'setMIFlag'?
   84 |     MIBFAdd2.setFlag(MachineInstr::FmNsz);
      |              ^~~~~~~
      |              setMIFlag
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include/llvm/CodeGen/MachineInstrBuilder.h:280:30: note: 'setMIFlag' declared here
  280 |   const MachineInstrBuilder &setMIFlag(MachineInstr::MIFlag Flag) const {
      |                              ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:87:13: error: no member named 'clearFlag' in 'llvm::MachineInstrBuilder'; did you mean to use '->' instead of '.'?
   87 |     MIBFAdd2.clearFlag(MachineInstr::FmNsz);
      |             ^
      |             ->
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:97:14: error: no member named 'setFlag' in 'llvm::MachineInstrBuilder'; did you mean 'setMIFlag'?
   97 |     MIBFSub2.setFlag(MachineInstr::FmNoNans);
      |              ^~~~~~~
      |              setMIFlag
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include/llvm/CodeGen/MachineInstrBuilder.h:280:30: note: 'setMIFlag' declared here
  280 |   const MachineInstrBuilder &setMIFlag(MachineInstr::MIFlag Flag) const {
      |                              ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:100:13: error: no member named 'clearFlag' in 'llvm::MachineInstrBuilder'; did you mean to use '->' instead of '.'?
  100 |     MIBFSub2.clearFlag(MachineInstr::FmNoNans);
      |             ^
      |             ->
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:110:14: error: no member named 'setFlag' in 'llvm::MachineInstrBuilder'; did you mean 'setMIFlag'?
  110 |     MIBFMul2.setFlag(MachineInstr::FmNoNans);
      |              ^~~~~~~
      |              setMIFlag
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include/llvm/CodeGen/MachineInstrBuilder.h:280:30: note: 'setMIFlag' declared here
  280 |   const MachineInstrBuilder &setMIFlag(MachineInstr::MIFlag Flag) const {
      |                              ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:113:13: error: no member named 'clearFlag' in 'llvm::MachineInstrBuilder'; did you mean to use '->' instead of '.'?
  113 |     MIBFMul2.clearFlag(MachineInstr::FmNoNans);
      |             ^
      |             ->
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/CodeGen/GlobalISel/CSETest.cpp:123:14: error: no member named 'setFlag' in 'llvm::MachineInstrBuilder'; did you mean 'setMIFlag'?
  123 |     MIBFDiv2.setFlag(MachineInstr::FmNoNans);
      |              ^~~~~~~

```

</details>

https://github.com/llvm/llvm-project/pull/123624