[llvm] [mlir] [OMPIRBuilder][debug] Fix debug info for variables in target region. (PR #118314)

Abid Qadeer via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 04:03:21 PST 2025


abidh wrote:

> Testing for LLVM components should be done in `llvm/tests` not `mlir`.

Hi @Meinersbur 

Thanks for taking a look. I see that we routinely add test in `mlir/test/Target/LLVMIR` for changes in `OMPIRBuilder.cpp` that relate to MLIR->LLVMIR translation as this PR is. I am not sure how that test can be moved into `llvm/tests`.

I will investigate if this scenario could be created in a `llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp` so that we can also add a test there but it seems difficult to me on an initial look.

Please let me know if the changes otherwise look reasonable.

https://github.com/llvm/llvm-project/pull/118314


More information about the llvm-commits mailing list