[llvm] PeepholeOpt: Remove unnecessary check for null TargetInstrInfo (PR #123929)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 03:25:38 PST 2025


https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/123929

>From e0469627508260757046914f4910cb880f6afd25 Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: Wed, 22 Jan 2025 17:12:11 +0700
Subject: [PATCH 1/2] PeepholeOpt: Remove unnecessary check for null
 TargetInstrInfo

This can never happen.
---
 llvm/lib/CodeGen/PeepholeOptimizer.cpp | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/llvm/lib/CodeGen/PeepholeOptimizer.cpp b/llvm/lib/CodeGen/PeepholeOptimizer.cpp
index 5d76d3688dfefa..01a42c51ab90e7 100644
--- a/llvm/lib/CodeGen/PeepholeOptimizer.cpp
+++ b/llvm/lib/CodeGen/PeepholeOptimizer.cpp
@@ -1991,11 +1991,6 @@ ValueTrackerResult ValueTracker::getNextSourceFromRegSequence() {
     // turn that into an assertion.
     return ValueTrackerResult();
 
-  if (!TII)
-    // We could handle the REG_SEQUENCE here, but we do not want to
-    // duplicate the code from the generic TII.
-    return ValueTrackerResult();
-
   SmallVector<RegSubRegPairAndIdx, 8> RegSeqInputRegs;
   if (!TII->getRegSequenceInputs(*Def, DefIdx, RegSeqInputRegs))
     return ValueTrackerResult();

>From 56e7be598a80eb8dce78f222b83518b2d4f09957 Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: Wed, 22 Jan 2025 18:25:15 +0700
Subject: [PATCH 2/2] Remove other 2 checks

---
 llvm/lib/CodeGen/PeepholeOptimizer.cpp | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/llvm/lib/CodeGen/PeepholeOptimizer.cpp b/llvm/lib/CodeGen/PeepholeOptimizer.cpp
index 01a42c51ab90e7..d56f040cf421fd 100644
--- a/llvm/lib/CodeGen/PeepholeOptimizer.cpp
+++ b/llvm/lib/CodeGen/PeepholeOptimizer.cpp
@@ -2019,11 +2019,6 @@ ValueTrackerResult ValueTracker::getNextSourceFromInsertSubreg() {
     // I.e., this may be turned into an assert.
     return ValueTrackerResult();
 
-  if (!TII)
-    // We could handle the REG_SEQUENCE here, but we do not want to
-    // duplicate the code from the generic TII.
-    return ValueTrackerResult();
-
   RegSubRegPair BaseReg;
   RegSubRegPairAndIdx InsertedReg;
   if (!TII->getInsertSubregInputs(*Def, DefIdx, BaseReg, InsertedReg))
@@ -2073,11 +2068,6 @@ ValueTrackerResult ValueTracker::getNextSourceFromExtractSubreg() {
   if (DefSubReg)
     return ValueTrackerResult();
 
-  if (!TII)
-    // We could handle the EXTRACT_SUBREG here, but we do not want to
-    // duplicate the code from the generic TII.
-    return ValueTrackerResult();
-
   RegSubRegPairAndIdx ExtractSubregInputReg;
   if (!TII->getExtractSubregInputs(*Def, DefIdx, ExtractSubregInputReg))
     return ValueTrackerResult();



More information about the llvm-commits mailing list