[llvm] [BOLT][AArch64] Support for pointer authentication (v2) (PR #120064)

Paschalis Mpeis via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 02:26:47 PST 2025


================
@@ -16,7 +27,15 @@ class InsertNegateRAState : public BinaryFunctionPass {
   /// Pass entry point
   Error runOnFunctions(BinaryContext &BC) override;
   void runOnFunction(BinaryFunction &BF);
+
+private:
+  /// Loops over all instructions and adds OpNegateRAState CFI
+  /// after any pointer signing or authenticating instructions.
+  /// Returns true, if any OpNegateRAState CFIs were added.
----------------
paschalis-mpeis wrote:

This is more on [doxygen](https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments) guidelines. But I also see this in a few places, eg [findAttributeInfo](https://github.com/llvm/llvm-project/blob/6b1db79887df19bc8e8c946108966aa6021c8b87/bolt/include/bolt/Core/DebugData.h#L61).

This is a nit anyway, so if you remember add it on a follow-up change, when we have some update on tests or the scheduling policy, etc.

https://github.com/llvm/llvm-project/pull/120064


More information about the llvm-commits mailing list