[llvm] [yaml2obj] Don't use uninitialized Type (PR #123274)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 00:52:48 PST 2025


================
@@ -25,3 +25,31 @@ Sections:
     Type:  0xabcd
   - Name:  decimal
     Type:  1234
+
+
----------------
jh7370 wrote:

Nit: We tend not to use double-blank lines to separate test cases, relying on the structure of `RUN` lines and YAML blocks to delineate them more easily.

I'd also recommend a comment immediately before the `RUN` line for each test case to help better highlight what is interesting about the testcase. In this case, it could say something like "Show that yaml2obj can handle `Type` fields that are neither section types nor other special chunk types".

https://github.com/llvm/llvm-project/pull/123274


More information about the llvm-commits mailing list