[llvm] [GISel] matchFPSelect to use FMINMAX IEEE variant (PR #123774)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 22:05:58 PST 2025


================
@@ -6442,27 +6442,27 @@ unsigned CombinerHelper::getFPMinMaxOpcForSelect(
   case CmpInst::FCMP_OGT:
   case CmpInst::FCMP_OGE:
     if (VsNaNRetVal == SelectPatternNaNBehaviour::RETURNS_OTHER)
-      return TargetOpcode::G_FMAXNUM;
+      return TargetOpcode::G_FMAXNUM_IEEE;
----------------
lialan wrote:

I checked how SDISel works on this, it seems the difference is that in GISel we are being more conservative because of -0 vs 0. 

Now that we are fixing G_FMAXNUM/G_FMINNUM to be similar to IEEE variants, I guess we can just relax the restriction on -0. 

https://github.com/llvm/llvm-project/pull/123774


More information about the llvm-commits mailing list