[llvm] [DXIL] Define and generate `DXILAttribute` and `DXILProperty` (PR #117072)

Chris B via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 08:25:11 PST 2025


================
@@ -177,6 +178,13 @@ DXILOperationDesc::DXILOperationDesc(const Record *R) {
     AttrRecs.push_back(CR);
   }
 
+  Recs = R->getValueAsListOfDefs("properties");
+
+  // Get property records
+  for (const Record *CR : Recs) {
+    PropRecs.push_back(CR);
+  }
----------------
llvm-beanz wrote:

nit:
```suggestion
  for (const Record *CR : Recs)
    PropRecs.push_back(CR);
```
see: https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements

https://github.com/llvm/llvm-project/pull/117072


More information about the llvm-commits mailing list