[llvm] 19bd2d6 - [ConstantFolding] Add ilogb in isMathLibCallNoop (#122582)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 20 09:19:12 PST 2025
Author: Kshitij Paranjape
Date: 2025-01-20T12:19:07-05:00
New Revision: 19bd2d610286300707b51135d3cff8bfb74322f0
URL: https://github.com/llvm/llvm-project/commit/19bd2d610286300707b51135d3cff8bfb74322f0
DIFF: https://github.com/llvm/llvm-project/commit/19bd2d610286300707b51135d3cff8bfb74322f0.diff
LOG: [ConstantFolding] Add ilogb in isMathLibCallNoop (#122582)
ilogb libcall was not being constant folded correctly. This patch adds
ilogb case in isMathLibCallNoop with correct error condition.
Fixes #101873
Added:
llvm/test/Transforms/InstSimplify/pr122582.ll
Modified:
llvm/lib/Analysis/ConstantFolding.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Analysis/ConstantFolding.cpp b/llvm/lib/Analysis/ConstantFolding.cpp
index 3e87ea0e90fd58..80c1277e631653 100644
--- a/llvm/lib/Analysis/ConstantFolding.cpp
+++ b/llvm/lib/Analysis/ConstantFolding.cpp
@@ -3940,6 +3940,9 @@ bool llvm::isMathLibCallNoop(const CallBase *Call,
case LibFunc_log10f:
return Op.isNaN() || (!Op.isZero() && !Op.isNegative());
+ case LibFunc_ilogb:
+ return !Op.isNaN() && !Op.isZero() && !Op.isInfinity();
+
case LibFunc_expl:
case LibFunc_exp:
case LibFunc_expf:
diff --git a/llvm/test/Transforms/InstSimplify/pr122582.ll b/llvm/test/Transforms/InstSimplify/pr122582.ll
new file mode 100644
index 00000000000000..0c341334b17730
--- /dev/null
+++ b/llvm/test/Transforms/InstSimplify/pr122582.ll
@@ -0,0 +1,213 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt < %s -passes=instsimplify -S | FileCheck %s
+
+define i32 @ilogbf_const1() {
+; CHECK-LABEL: define i32 @ilogbf_const1() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 7.000000e+00)
+; CHECK-NEXT: ret i32 2
+;
+ %r = call i32 @ilogbf(float 7.000000e+00)
+ ret i32 %r
+}
+
+define i32 @ilogb_const1() {
+; CHECK-LABEL: define i32 @ilogb_const1() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -7.000000e+00)
+; CHECK-NEXT: ret i32 2
+;
+ %r = call i32 @ilogb(double -7.000000e+00)
+ ret i32 %r
+}
+
+define i32 @ilogbf_const2() {
+; CHECK-LABEL: define i32 @ilogbf_const2() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 5.000000e-01)
+; CHECK-NEXT: ret i32 -1
+;
+ %r = call i32 @ilogbf(float 5.000000e-01)
+ ret i32 %r
+}
+
+define i32 @ilogb_const2() {
+; CHECK-LABEL: define i32 @ilogb_const2() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -5.000000e-01)
+; CHECK-NEXT: ret i32 -1
+;
+ %r = call i32 @ilogb(double -5.000000e-01)
+ ret i32 %r
+}
+
+define i32 @ilogbf_zero() {
+; CHECK-LABEL: define i32 @ilogbf_zero() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0.000000e+00)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogbf(float 0.000000e+00)
+ ret i32 %r
+}
+
+define i32 @ilogb_zero() {
+; CHECK-LABEL: define i32 @ilogb_zero() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0.000000e+00)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogb(double 0.000000e+00)
+ ret i32 %r
+}
+
+define i32 @ilogbf_neg_zero() {
+; CHECK-LABEL: define i32 @ilogbf_neg_zero() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float -0.000000e+00)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogbf(float -0.000000e+00)
+ ret i32 %r
+}
+
+define i32 @ilogb_neg_zero() {
+; CHECK-LABEL: define i32 @ilogb_neg_zero() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -0.000000e+00)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogb(double -0.000000e+00)
+ ret i32 %r
+}
+
+define i32 @ilogbf_inf() {
+; CHECK-LABEL: define i32 @ilogbf_inf() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF0000000000000)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogbf(float 0x7FF0000000000000)
+ ret i32 %r
+}
+
+define i32 @ilogb_inf() {
+; CHECK-LABEL: define i32 @ilogb_inf() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF0000000000000)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogb(double 0x7FF0000000000000)
+ ret i32 %r
+}
+
+define i32 @ilogbf_nan() {
+; CHECK-LABEL: define i32 @ilogbf_nan() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF8000000000000)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogbf(float 0x7FF8000000000000)
+ ret i32 %r
+}
+
+define i32 @ilogb_nan() {
+; CHECK-LABEL: define i32 @ilogb_nan() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF8000000000000)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogb(double 0x7FF8000000000000)
+ ret i32 %r
+}
+
+define i32 @ilogbf_zero_readnone() {
+; CHECK-LABEL: define i32 @ilogbf_zero_readnone() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0.000000e+00) #[[ATTR1:[0-9]+]]
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogbf(float 0.000000e+00) readnone
+ ret i32 %r
+}
+
+define i32 @ilogb_zero_readnone() {
+; CHECK-LABEL: define i32 @ilogb_zero_readnone() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0.000000e+00) #[[ATTR1]]
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogb(double 0.000000e+00) readnone
+ ret i32 %r
+}
+
+define i32 @ilogbf_neg_zero_readnone() {
+; CHECK-LABEL: define i32 @ilogbf_neg_zero_readnone() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float -0.000000e+00) #[[ATTR1]]
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogbf(float -0.000000e+00) readnone
+ ret i32 %r
+}
+
+define i32 @ilogb_neg_zero_readnone() {
+; CHECK-LABEL: define i32 @ilogb_neg_zero_readnone() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -0.000000e+00) #[[ATTR1]]
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogb(double -0.000000e+00) readnone
+ ret i32 %r
+}
+
+define i32 @ilogbf_inf_readnone() {
+; CHECK-LABEL: define i32 @ilogbf_inf_readnone() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF0000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogbf(float 0x7FF0000000000000) readnone
+ ret i32 %r
+}
+
+define i32 @ilogb_inf_readnone() {
+; CHECK-LABEL: define i32 @ilogb_inf_readnone() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF0000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogb(double 0x7FF0000000000000) readnone
+ ret i32 %r
+}
+
+define i32 @ilogbf_nan_readnone() {
+; CHECK-LABEL: define i32 @ilogbf_nan_readnone() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF8000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogbf(float 0x7FF8000000000000) readnone
+ ret i32 %r
+}
+
+define i32 @ilogb_nan_readnone() {
+; CHECK-LABEL: define i32 @ilogb_nan_readnone() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF8000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogb(double 0x7FF8000000000000) readnone
+ ret i32 %r
+}
+
+define i32 @ilogbf_poison() {
+; CHECK-LABEL: define i32 @ilogbf_poison() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float poison)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogbf(float poison)
+ ret i32 %r
+}
+
+define i32 @ilogb_poison() {
+; CHECK-LABEL: define i32 @ilogb_poison() {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double poison)
+; CHECK-NEXT: ret i32 [[R]]
+;
+ %r = call i32 @ilogb(double poison)
+ ret i32 %r
+}
+
+define i32 @ilogb_const1_1() strictfp {
+; CHECK-LABEL: define i32 @ilogb_const1_1(
+; CHECK-SAME: ) #[[ATTR0:[0-9]+]] {
+; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -7.000000e+00)
+; CHECK-NEXT: ret i32 2
+;
+ %r = call i32 @ilogb(double -7.000000e+00)
+ ret i32 %r
+}
+
+declare i32 @ilogbf(float)
+declare i32 @ilogb(double)
More information about the llvm-commits
mailing list