[llvm] de58693 - [ORC][MachO] Add a TODO comment.
Lang Hames via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 19 15:25:25 PST 2025
Author: Lang Hames
Date: 2025-01-20T10:25:18+11:00
New Revision: de586937648d360d8c4741cd34f633ea92316874
URL: https://github.com/llvm/llvm-project/commit/de586937648d360d8c4741cd34f633ea92316874
DIFF: https://github.com/llvm/llvm-project/commit/de586937648d360d8c4741cd34f633ea92316874.diff
LOG: [ORC][MachO] Add a TODO comment.
Added:
Modified:
llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
Removed:
################################################################################
diff --git a/llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp b/llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
index 8e66d028f21ce8..f8f65ec3b4cf3c 100644
--- a/llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
@@ -583,6 +583,12 @@ MachOPlatform::MachOPlatform(
return;
// (5) Associate runtime support functions.
+ // TODO: Consider moving this above (4) to make runtime support functions
+ // available to the bootstrap completion graph. We'd just need to be
+ // sure that the runtime support functions are fully usable before any
+ // bootstrap completion actions use them (e.g. the ORC runtime
+ // macho_platform object would have to have been created and
+ // initialized).
if ((Err = associateRuntimeSupportFunctions()))
return;
}
More information about the llvm-commits
mailing list