[clang] [llvm] [NFC][AMDGPU] Clean-up feature parsing for AMDGCNSPIRV. (PR #123519)

Alex Voicu via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 19 09:37:37 PST 2025


================
@@ -323,43 +323,59 @@ void AMDGPU::fillAMDGPUFeatureMap(StringRef GPU, const Triple &T,
                                   StringMap<bool> &Features) {
   // XXX - What does the member GPU mean if device name string passed here?
   if (T.isSPIRV() && T.getOS() == Triple::OSType::AMDHSA) {
-    // AMDGCN SPIRV must support the union of all AMDGCN features.
+    // AMDGCN SPIRV must support the union of all AMDGCN features. This list
----------------
AlexVlx wrote:

Possibly, although tablegen is already a bit of a monster IMHO.

https://github.com/llvm/llvm-project/pull/123519


More information about the llvm-commits mailing list