[llvm] [Object] Avoid repeated hash lookups (NFC) (PR #123448)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 17 21:02:27 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-binary-utilities
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/123448.diff
1 Files Affected:
- (modified) llvm/lib/Object/GOFFObjectFile.cpp (+4-4)
``````````diff
diff --git a/llvm/lib/Object/GOFFObjectFile.cpp b/llvm/lib/Object/GOFFObjectFile.cpp
index e3c4383d27aadb..db1e7e704f62e1 100644
--- a/llvm/lib/Object/GOFFObjectFile.cpp
+++ b/llvm/lib/Object/GOFFObjectFile.cpp
@@ -190,8 +190,8 @@ const uint8_t *GOFFObjectFile::getSymbolEsdRecord(DataRefImpl Symb) const {
}
Expected<StringRef> GOFFObjectFile::getSymbolName(DataRefImpl Symb) const {
- if (EsdNamesCache.count(Symb.d.a)) {
- auto &StrPtr = EsdNamesCache[Symb.d.a];
+ if (auto It = EsdNamesCache.find(Symb.d.a); It != EsdNamesCache.end()) {
+ auto &StrPtr = It->second;
return StringRef(StrPtr.second.get(), StrPtr.first);
}
@@ -459,8 +459,8 @@ uint64_t GOFFObjectFile::getSectionSize(DataRefImpl Sec) const {
// a contiguous sequence of bytes.
Expected<ArrayRef<uint8_t>>
GOFFObjectFile::getSectionContents(DataRefImpl Sec) const {
- if (SectionDataCache.count(Sec.d.a)) {
- auto &Buf = SectionDataCache[Sec.d.a];
+ if (auto It = SectionDataCache.find(Sec.d.a); It != SectionDataCache.end()) {
+ auto &Buf = It->second;
return ArrayRef<uint8_t>(Buf);
}
uint64_t SectionSize = getSectionSize(Sec);
``````````
</details>
https://github.com/llvm/llvm-project/pull/123448
More information about the llvm-commits
mailing list