[llvm] [TableGen] Use vector constructor instead of calling append or emplace_back on an empty vector. NFC (PR #123442)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 17 20:19:18 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-tablegen
Author: Craig Topper (topperc)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/123442.diff
1 Files Affected:
- (modified) llvm/utils/TableGen/Common/CodeGenSchedule.cpp (+7-8)
``````````diff
diff --git a/llvm/utils/TableGen/Common/CodeGenSchedule.cpp b/llvm/utils/TableGen/Common/CodeGenSchedule.cpp
index a5ca060533bcef..ebe066901d2d10 100644
--- a/llvm/utils/TableGen/Common/CodeGenSchedule.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenSchedule.cpp
@@ -1711,24 +1711,23 @@ void CodeGenSchedModels::inferFromRW(ArrayRef<unsigned> OperWrites,
dbgs() << ") ");
// Create a seed transition with an empty PredTerm and the expanded sequences
// of SchedWrites for the current SchedClass.
- std::vector<PredTransition> LastTransitions;
- LastTransitions.emplace_back();
+ std::vector<PredTransition> LastTransitions(1);
for (unsigned WriteIdx : OperWrites) {
IdxVec WriteSeq;
expandRWSequence(WriteIdx, WriteSeq, /*IsRead=*/false);
- LastTransitions[0].WriteSequences.emplace_back();
- SmallVectorImpl<unsigned> &Seq = LastTransitions[0].WriteSequences.back();
- Seq.append(WriteSeq.begin(), WriteSeq.end());
+ SmallVectorImpl<unsigned> &Seq =
+ LastTransitions[0].WriteSequences.emplace_back(WriteSeq.begin(),
+ WriteSeq.end());
LLVM_DEBUG(dbgs() << "("; dumpIdxVec(Seq); dbgs() << ") ");
}
LLVM_DEBUG(dbgs() << " Reads: ");
for (unsigned ReadIdx : OperReads) {
IdxVec ReadSeq;
expandRWSequence(ReadIdx, ReadSeq, /*IsRead=*/true);
- LastTransitions[0].ReadSequences.emplace_back();
- SmallVectorImpl<unsigned> &Seq = LastTransitions[0].ReadSequences.back();
- Seq.append(ReadSeq.begin(), ReadSeq.end());
+ SmallVectorImpl<unsigned> &Seq =
+ LastTransitions[0].ReadSequences.emplace_back(ReadSeq.begin(),
+ ReadSeq.end());
LLVM_DEBUG(dbgs() << "("; dumpIdxVec(Seq); dbgs() << ") ");
}
LLVM_DEBUG(dbgs() << '\n');
``````````
</details>
https://github.com/llvm/llvm-project/pull/123442
More information about the llvm-commits
mailing list