[compiler-rt] Found one more delta to unbreak build for z/os (PR #82789)

Sean Perry via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 10:38:18 PST 2025


================
@@ -368,10 +368,11 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) {
 #endif
 }
 
-#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE)
+#elif defined(QUAD_PRECISION)
+#if defined(CRT_HAS_TF_MODE)
+#if defined(CRT_HAS_IEEE_TF)
----------------
perry-ca wrote:

I don't think that #if structure you suggest works with sparc.  The logic of the sequence isn't semantically accurate either because the error in the else clause says all of the other conditions above are various TF mode and CRT_LDBL_128BIT is not one.

We will also be losing the check for CRT_HAS_TF_MODE.  

The logic I tried to capture in my changes is "if has a TF mode pick the mode (or give an error), otherwise if has 128-bit long double ...".  I don't think we can flatten this.

https://github.com/llvm/llvm-project/pull/82789


More information about the llvm-commits mailing list