[clang] [llvm] [StrTable] Switch diag group names to `llvm::StringTable` (PR #123302)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 10:35:29 PST 2025


================
@@ -51,6 +53,14 @@ class StringTable {
     constexpr Offset() = default;
     constexpr Offset(unsigned Value) : Value(Value) {}
 
+    constexpr bool operator==(const Offset &RHS) const {
----------------
dwblaikie wrote:

Minor convention, but prefer non-member (can still be defined inline as a friend, so not a huge syntactic overhead) op overloads for equal conversion (especially since this type is implicitly convertible) on LHS and RHS, perhaps?

https://github.com/llvm/llvm-project/pull/123302


More information about the llvm-commits mailing list