[llvm] [FMV][GlobalOpt] Do not statically resolve non-FMV callers. (PR #123383)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 10:25:31 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff ee1c85225235c4353555a17b73ba16a2f177265b 8e061e9a599b0bab2a8f7b9464ad6849548b653c --extensions cpp -- llvm/lib/Transforms/IPO/GlobalOpt.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Transforms/IPO/GlobalOpt.cpp b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
index 4e9cef97b6..eb97d8b4a7 100644
--- a/llvm/lib/Transforms/IPO/GlobalOpt.cpp
+++ b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
@@ -2785,7 +2785,7 @@ static bool OptimizeNonTrivialIFuncs(
       } else {
         // We can't reason much about non-FMV callers. Just pick the highest
         // priority callee if it matches, otherwise bail.
-        //if (I > 0 || !implies(CallerBits, CalleeBits))
+        // if (I > 0 || !implies(CallerBits, CalleeBits))
         //
         // FIXME: This is causing a regression in the llvm test suite,
         // specifically a 'predres' version is unexpectedly trapping on
@@ -2794,7 +2794,7 @@ static bool OptimizeNonTrivialIFuncs(
         // command line option, or target attribute to deduce whether a
         // feature is available. However, there is no guarantee that in
         // reality the host supports those implied features.
-          continue;
+        continue;
       }
       auto &Calls = CallSites[Caller];
       for (CallBase *CS : Calls)

``````````

</details>


https://github.com/llvm/llvm-project/pull/123383


More information about the llvm-commits mailing list