[llvm] [NFC] Move RemoveRedundantDbgInstrs outside of inner loop in JumpThreading (PR #123008)

[Stephen Tozer via llvm-commits]

https://github.com/SLTozer commented:

I've given a try at reproducing the prior issue in a build of LLVM and the llvm-test-suite with `-fsanitize=thread`, and didn't see it appear, so this is probably fine to land - it's possible that the call to remove redundant debug records is no longer necessary at all, but optimizing it at the very least is useful. Just be aware that the issue might still exist on some inputs I've not tested, so a revert might be necessary if it appears on the buildbots or somewhere downstream.

This LGTM, but before merging: I've left some inline comments that should be addressed, and when you merge this make sure that the [NFC] tag is removed from the commit message - besides the fact that it could be misleading if this patch indeed results in downstream errors, it does clearly have a small change on output in some cases now.

https://github.com/llvm/llvm-project/pull/123008