[llvm] Revert "[YAML] Init local var not set by some branches" (PR #123238)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 12:27:18 PST 2025


https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/123238

Reverts llvm/llvm-project#123137

It's a bug according to https://github.com/llvm/llvm-project/pull/123137#pullrequestreview-2555328813

>From 7570effc913ab3b683c7b4f9376735e83946e4be Mon Sep 17 00:00:00 2001
From: Vitaly Buka <vitalybuka at gmail.com>
Date: Thu, 16 Jan 2025 12:26:11 -0800
Subject: [PATCH] Revert "[YAML] Init local var not set by some branches
 (#123137)"

This reverts commit 319c1190939960d009c88baf0d5fb97a549b7a57.
---
 llvm/lib/ObjectYAML/ELFYAML.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/ObjectYAML/ELFYAML.cpp b/llvm/lib/ObjectYAML/ELFYAML.cpp
index 83e6cf76dd746f..7e94d01a971534 100644
--- a/llvm/lib/ObjectYAML/ELFYAML.cpp
+++ b/llvm/lib/ObjectYAML/ELFYAML.cpp
@@ -1588,7 +1588,7 @@ static bool isInteger(StringRef Val) {
 
 void MappingTraits<std::unique_ptr<ELFYAML::Chunk>>::mapping(
     IO &IO, std::unique_ptr<ELFYAML::Chunk> &Section) {
-  ELFYAML::ELF_SHT Type = ELF::ET_NONE;
+  ELFYAML::ELF_SHT Type;
   StringRef TypeStr;
   if (IO.outputting()) {
     if (auto *S = dyn_cast<ELFYAML::Section>(Section.get()))



More information about the llvm-commits mailing list