[llvm] [mlir] [TOSA] Add Tosa_Shape type and ConstShapeOp (PR #122547)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 09:52:28 PST 2025


Jerry-Ge wrote:

> > > Thanks for the PR @Jerry-Ge! I had a look and left a few comments below, largely they're just questions along with some requests for better test coverage
> > 
> > 
> > Thanks Luke! This patch is primarily for aligning the internal and upstream branches. To keep things clean, I will achieve this in multiple patches.
> 
> Great work @Jerry-Ge, It would be great though to keep patches nicely self-contained and layered. So please let's try and do this. If something can be fixed in this patch we should try and do it; not let it spill over to next ones.

Thanks for the comments. Yes, I will try my best to achieve that. 

https://github.com/llvm/llvm-project/pull/122547


More information about the llvm-commits mailing list