[lld] [llvm] RFC: [LLD] [COFF] Fix linking MSVC generated implib header objects (PR #122811)

[Jacek Caban via llvm-commits]

cjacek wrote:

Interesting findings, thanks!

> For the former issue, I'm not sure if there's much of an action we need to take; it is very distracting when trying to figure out how things really work, but I'm not sure if resolving this is relevant for this case.

Agreed, sounds doesn't sounds like something we need to worry about.

> Should we add a `DefinedRegular` subclass which ignores the offset? That's maybe the most efficient way around it, without needing to litter `DefinedRegular` with a condition in e.g. the `getRVA()` method. (Alternatively, `DefinedRegular` would need a flag about whether to ignore the Value offset or not.)

I guess instead of a flag, `DefinedRegular` could just store the offset itself, copy it from `coff_symbol_generic` in the constructor and use it internally instead. In this case, we could then just override it. A new symbol type works too.

https://github.com/llvm/llvm-project/pull/122811