[llvm] IVDesc: unify RecurKinds IAnyOf and FAnyOf (PR #118393)

Mel Chen via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 03:26:44 PST 2025


================
@@ -209,7 +207,9 @@ class RecurrenceDescriptor {
 
   RecurKind getRecurrenceKind() const { return Kind; }
 
-  unsigned getOpcode() const { return getOpcode(getRecurrenceKind()); }
+  unsigned getOpcode() const {
+    return getOpcode(getRecurrenceKind(), getRecurrenceType());
----------------
Mel-Chen wrote:

> Presumably that means the opcode is never actually used for anything, at least for the AnyOf path?

Yes, in my opinion, non-arithmetic reductions do not require to call `getOpcode()`. So #118777 starts to clean up some situations where `getOpcode()` is not needed at the path but still called.
It was also present in SLPVectorizer and #122239 has been cleared.

https://github.com/llvm/llvm-project/pull/118393


More information about the llvm-commits mailing list