[llvm] [NVPTX] Remove `NVPTX::IMAD` opcode, and rely on intruction selection only (PR #121724)
Alex MacLean via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 14 12:02:07 PST 2025
================
@@ -4442,14 +4441,8 @@ PerformADDCombineWithOperands(SDNode *N, SDValue N0, SDValue N1,
if (!N0.getNode()->hasOneUse())
return SDValue();
----------------
AlexMaclean wrote:
Looks like this logic here applied some cost heuristics to `mad` folding. It seems like we don't have very good tests for this, and I'm not sure these heuristics are right, but we should probably be careful about discarding this behavior. If a mul has many uses this transformation could increase register pressure. Is there data/rationale for removing this constraint?
https://github.com/llvm/llvm-project/pull/121724
More information about the llvm-commits
mailing list