[llvm] IVDesc: unify RecurKinds IAnyOf and FAnyOf (PR #118393)

David Sherwood via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 07:05:18 PST 2025


================
@@ -48,10 +48,8 @@ enum class RecurKind {
   FMinimum, ///< FP min with llvm.minimum semantics
   FMaximum, ///< FP max with llvm.maximum semantics
   FMulAdd,  ///< Sum of float products with llvm.fmuladd(a * b + sum).
-  IAnyOf,   ///< Any_of reduction with select(icmp(),x,y) where one of (x,y) is
-            ///< loop invariant, and both x and y are integer type.
-  FAnyOf,   ///< Any_of reduction with select(fcmp(),x,y) where one of (x,y) is
-            ///< loop invariant, and both x and y are integer type.
+  AnyOf,    ///< Any_of reduction with select(icmp(),x,y) where one of (x,y) is
----------------
david-arm wrote:

The comment suggests it's always `icmp()`, but it could be icmp or fcmp. Perhaps you can rewrite this as:

```
  ///< Any_of reduction with select(cmp,x,y) where cmp is either the result of
  ///< icmp() or fcmp(), and one of (x,y) is loop invariant.
```

https://github.com/llvm/llvm-project/pull/118393


More information about the llvm-commits mailing list