https://github.com/lhutton1 commented: Thanks for the PR @Jerry-Ge! I had a look and left a few comments below, largely they're just questions along with some requests for better test coverage https://github.com/llvm/llvm-project/pull/122547