https://github.com/Lukacma commented: Thank you for the patch Carol it looks good ! I think we should also add dependency test for the new features, to both TargetParserTest.cpp and aarch64-implied-sme-features.c . https://github.com/llvm/llvm-project/pull/121935