[llvm] 0fe8469 - SLPVectorizer: strip bad FIXME (NFC) (#122888)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 03:28:00 PST 2025


Author: Ramkumar Ramachandra
Date: 2025-01-14T11:27:55Z
New Revision: 0fe8469e08cfe5bbd4cd7ee42a8b931560ca041c

URL: https://github.com/llvm/llvm-project/commit/0fe8469e08cfe5bbd4cd7ee42a8b931560ca041c
DIFF: https://github.com/llvm/llvm-project/commit/0fe8469e08cfe5bbd4cd7ee42a8b931560ca041c.diff

LOG: SLPVectorizer: strip bad FIXME (NFC) (#122888)

Follow up on 4a0d53a (PatternMatch: migrate to CmpPredicate) to get rid
of the FIXME it introduced in SLPVectorizer: the FIXME is bad, and we'd
get no testable impact by using CmpPredicate::getMatching here.

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index 2742c3777c1ed6..b0b8f8249d657b 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -11529,7 +11529,6 @@ BoUpSLP::getEntryCost(const TreeEntry *E, ArrayRef<Value *> VectorizedVals,
                                      ? CmpInst::BAD_FCMP_PREDICATE
                                      : CmpInst::BAD_ICMP_PREDICATE;
       auto MatchCmp = m_Cmp(CurrentPred, m_Value(), m_Value());
-      // FIXME: Use CmpPredicate::getMatching here.
       if ((!match(VI, m_Select(MatchCmp, m_Value(), m_Value())) &&
            !match(VI, MatchCmp)) ||
           (CurrentPred != static_cast<CmpInst::Predicate>(VecPred) &&


        


More information about the llvm-commits mailing list