[llvm] [AArch64][GISel] Use Register instead of MCRegister for markPhysRegUsed in CallLowering. (PR #122853)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 21:49:59 PST 2025


================
@@ -207,14 +207,14 @@ struct IncomingArgHandler : public CallLowering::IncomingValueHandler {
   /// How the physical register gets marked varies between formal
   /// parameters (it's a basic-block live-in), and a call instruction
   /// (it's an implicit-def of the BL).
-  virtual void markPhysRegUsed(MCRegister PhysReg) = 0;
+  virtual void markPhysRegUsed(Register PhysReg) = 0;
 };
 
 struct FormalArgHandler : public IncomingArgHandler {
   FormalArgHandler(MachineIRBuilder &MIRBuilder, MachineRegisterInfo &MRI)
       : IncomingArgHandler(MIRBuilder, MRI) {}
 
-  void markPhysRegUsed(MCRegister PhysReg) override {
+  void markPhysRegUsed(Register PhysReg) override {
     MIRBuilder.getMRI()->addLiveIn(PhysReg);
----------------
topperc wrote:

It's not a virtual register when FormalArgHandler::markPhysRegUsed is called. It's only virtual when ReturnedArgCallReturnHandler::markPhysRegUsed is called. This is a virtual function.

https://github.com/llvm/llvm-project/pull/122853


More information about the llvm-commits mailing list