[llvm] [AMDGPU][True16][MC] true16 for v_cmp_lt_f16 (PR #122499)

Ivan Kosarev via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 09:53:13 PST 2025


================
@@ -1254,6 +1255,20 @@ void AMDGPUDisassembler::convertVOPCDPPInst(MCInst &MI) const {
                          AMDGPU::OpName::src1_modifiers);
 }
 
+void AMDGPUDisassembler::convertVOPC64DPPInst(MCInst &MI) const {
+  unsigned Opc = MI.getOpcode();
+  unsigned DescNumOps = MCII->get(Opc).getNumOperands();
+
+  convertTrue16OpSel(MI);
+
+  if (MI.getNumOperands() < DescNumOps &&
+      AMDGPU::hasNamedOperand(Opc, AMDGPU::OpName::op_sel)) {
+    auto Mods = collectVOPModifiers(MI);
----------------
kosarev wrote:

Nit: it would help reading if we specify the type.
```suggestion
    VOPModifiers Mods = collectVOPModifiers(MI);
```

https://github.com/llvm/llvm-project/pull/122499


More information about the llvm-commits mailing list