[llvm] [VPlan] Verify scalar types in VPlanVerifier. NFCI (PR #122679)

[David Sherwood via llvm-commits]

================
@@ -195,6 +197,9 @@ bool VPlanVerifier::verifyVPBasicBlock(const VPBasicBlock *VPBB) {
       return false;
     }
     for (const VPValue *V : R.definedValues()) {
+      // Verify that recipes' operands have matching types.
+      TypeInfo.inferScalarType(V);
----------------
david-arm wrote:

It looks like you're dropping the return value here so I'm not sure what exactly you're verifying. Are you essentially relying upon the user building with asserts to catch any issues? It feels like we should be doing something here and printing out to `errs()` if something looks wrong?

https://github.com/llvm/llvm-project/pull/122679