[llvm] [BOLT] Enable hugify for AArch64 (PR #117158)

Alexey Moksyakov via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 06:25:28 PST 2025


yavtuk wrote:

>From my point of view it depends on what functionality is implemented,
for example bolt/test/runtime/AArch64/hugify.c, 
this test checks that the binary layout is correct and
can be launched, I think in current state it can be placed in the platform independent part 

bolt/test/runtime/hugify.c

if the test will check a hardware specific implementation, 
for example, adrp + add pair instructions,
the one should be moved under platform specific directory

bolt/test/runtime/aarch64/hugify.c

but it must contain the checking for adrp + add instrs.


Regarding the test #120267, it contains aarch64 specific checking for relocation

`
CHECK-RELOCS: [[#%x,OFF:]] [[#%x,INFO_DYN:]] R_AARCH64_RELATIVE [[#%x,ADDR:]]
`

I think it should be under aarch64 directory.

if this test platform independent than CHECK-RELOCS should be removed 
and label checking is enough.

`
CHECK-ENTRYS: Binary Function "main" after building cfg {
`


https://github.com/llvm/llvm-project/pull/117158


More information about the llvm-commits mailing list