[llvm] [mlir] [mlir][EmitC] Add MathToEmitC pass for math function lowering to EmitC (PR #113799)
Tomer Solomon via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 13 05:09:06 PST 2025
recursion-man wrote:
Hi @marbre and @simon-camp,
I hope you're doing well. I wanted to follow up on my MathToEmitC PR. I’ve been away for the past couple of months due to personal commitments, but I’m now back and ready to move this forward. Thanks for your patience!
Here’s a quick summary of the changes since we last discussed:
Following @simon-camp’s suggestion, I replaced the _MathToEmitCLanguageTarget_ attribute with a _LanguageTarget_ enum in Dialect/EmitC/Transforms/Passes.h. The enum now supports c99 and cpp11 for better precision.
Based on @marbre’s feedback, I kept the scope focused—avoiding module-level attributes or new ops for now.
I’d appreciate it if you could take another look and let me know if there’s anything else I should address.
Thanks again for your input and support!
https://github.com/llvm/llvm-project/pull/113799
More information about the llvm-commits
mailing list