[llvm] [lit] Ignore src permissions when copying lit_test_times (PR #121377)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 00:50:11 PST 2025


https://github.com/jh7370 commented:

> Is there an actual concern that I need to respond to here?

Not with `cp`. I was just confused, having recently been looking at the POSIX spec for different reasons. On further read, it turns out that I misread the spec anyway!

I was concerned that this was some special behaviour needed to cope with bazel that would easily be forgotten in a future change. I've taken a second look at the test and understand more about what is going on, but I'm now confused by why https://github.com/llvm/llvm-project/commit/1dbcb79498d0db465234c68adf52b88e7f87a832 isn't sufficient?

https://github.com/llvm/llvm-project/pull/121377


More information about the llvm-commits mailing list