[llvm] [Coverage] MCDC: Move findIndependencePairs deferred into MCDCRecord (PR #121188)

NAKAMURA Takumi via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 5 21:25:21 PST 2025


================
@@ -494,10 +498,10 @@ struct MCDCRecord {
   /// TestVectors requires a translation from a ordinal position to actual
   /// condition ID. This is done via PosToID[].
   bool isConditionIndependencePairCovered(unsigned Condition) const {
+    assert(IndependencePairs);
     auto It = PosToID.find(Condition);
-    if (It != PosToID.end())
-      return IndependencePairs.contains(It->second);
-    llvm_unreachable("Condition ID without an Ordinal mapping");
+    assert(It != PosToID.end() && "Condition ID without an Ordinal mapping");
----------------
chapuni wrote:

Do we expect "satisfies or crash" here? I wanted to eliminate the condition.

https://github.com/llvm/llvm-project/pull/121188


More information about the llvm-commits mailing list