[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #117268)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 17:09:49 PST 2025


================
@@ -630,6 +630,11 @@ void toolchains::MinGW::AddHIPIncludeArgs(const ArgList &DriverArgs,
   RocmInstallation->AddHIPIncludeArgs(DriverArgs, CC1Args);
 }
 
+void toolchains::MinGW::addSYCLIncludeArgs(const ArgList &DriverArgs,
+                                           ArgStringList &CC1Args) const {
+  SYCLInstallation->addSYCLIncludeArgs(DriverArgs, CC1Args);
----------------
MaskRay wrote:

is this needed or tested?

If you add an overload to a specific ToolChain, ensure that this ToolChain gets coverage. Otherwise someone could find the function unneeded and delete it.

https://github.com/llvm/llvm-project/pull/117268


More information about the llvm-commits mailing list