[llvm] Add SD matchers and unit test coverage for ISD::VECTOR_SHUFFLE (PR #119592)
Min-Yih Hsu via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 31 15:26:09 PST 2024
================
@@ -547,6 +547,39 @@ struct BinaryOpc_match {
}
};
+/// Matching while capturing mask
+template <typename T0, typename T1, typename T2> struct SDShuffle_match {
+ T0 Op1;
+ T1 Op2;
+ T2 Mask;
+
+ SDShuffle_match(const T0 &Op1, const T1 &Op2, const T2 &Mask)
+ : Op1(Op1), Op2(Op2), Mask(Mask) {}
+
+ template <typename MatchContext>
+ bool match(const MatchContext &Ctx, SDValue N) {
+ if (auto *I = dyn_cast<ShuffleVectorSDNode>(N)) {
+ return Op1.match(Ctx, I->getOperand(0)) &&
+ Op2.match(Ctx, I->getOperand(1)) && Mask.match(I->getMask());
+ }
+ return false;
+ }
+};
+struct m_Mask {
+ ArrayRef<int> MaskRef;
----------------
mshockwave wrote:
> however to m_SpecificMask should we be passing MaskData or Mask by value for a comparison?
In this case you probably have to use `MaskData` because you haven't checked the correctness of `Mask` at the time you test m_SpecificMask. Unless you move that correctness check (line 145 to 147) to the front, in which case it doesn't matter which one you use.
https://github.com/llvm/llvm-project/pull/119592
More information about the llvm-commits
mailing list