[llvm] [MemProf][PGO] Prevent dropping of profile metadata during optimization (PR #121359)

[Nikita Popov via llvm-commits]

================
@@ -3379,6 +3379,10 @@ void llvm::combineMetadata(Instruction *K, const Instruction *J,
           K->setMetadata(Kind,
             MDNode::getMostGenericAlignmentOrDereferenceable(JMD, KMD));
         break;
+      case LLVMContext::MD_memprof:
+      case LLVMContext::MD_callsite:
+        // Preserve !memprof and !callsite metadata on K.
----------------
nikic wrote:

Shouldn't this be merging the contents of the memprof and callsite metadata, rather than taking it from one of the instructions?

https://github.com/llvm/llvm-project/pull/121359