[lldb] [llvm] [LLDB][Minidump] Make workaround for the Dynamic loader issue (PR #120166)

Pavel Labath via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 26 02:27:36 PST 2024


================
@@ -89,8 +89,11 @@ Status MinidumpFileBuilder::AddHeaderAndCalculateDirectories() {
         "Failed to fill in header and directory "
         "sections. Written / Expected (%" PRIx64 " / %" PRIx64 ")",
         new_offset, m_saved_data_size);
-
   return error;
+  if (error.Fail())
+    return error;
----------------
labath wrote:

Remove the extra return?

(It would be nice to at least have a test that verifies that the lldb stream is actually written)

https://github.com/llvm/llvm-project/pull/120166


More information about the llvm-commits mailing list