[llvm] 4884b1b - [TableGen][GISel] Simplify checks for BasicBlockSDNode (NFC) (#121098)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 25 02:32:05 PST 2024
Author: Sergei Barannikov
Date: 2024-12-25T13:32:02+03:00
New Revision: 4884b1b08a13af430620e7104aa58710a70f618c
URL: https://github.com/llvm/llvm-project/commit/4884b1b08a13af430620e7104aa58710a70f618c
DIFF: https://github.com/llvm/llvm-project/commit/4884b1b08a13af430620e7104aa58710a70f618c.diff
LOG: [TableGen][GISel] Simplify checks for BasicBlockSDNode (NFC) (#121098)
Added:
Modified:
llvm/utils/TableGen/GlobalISelEmitter.cpp
Removed:
################################################################################
diff --git a/llvm/utils/TableGen/GlobalISelEmitter.cpp b/llvm/utils/TableGen/GlobalISelEmitter.cpp
index 4250b57581f63e..5038be7b24fbcb 100644
--- a/llvm/utils/TableGen/GlobalISelEmitter.cpp
+++ b/llvm/utils/TableGen/GlobalISelEmitter.cpp
@@ -992,27 +992,24 @@ Error GlobalISelEmitter::importChildMatcher(
// Check MBB's before the type check since they are not a known type.
if (!SrcChild.isLeaf()) {
- if (SrcChild.getOperator()->isSubClassOf("SDNode")) {
- auto &ChildSDNI = CGP.getSDNodeInfo(SrcChild.getOperator());
- if (ChildSDNI.getSDClassName() == "BasicBlockSDNode") {
- OM.addPredicate<MBBOperandMatcher>();
- return Error::success();
- }
- if (SrcChild.getOperator()->getName() == "timm") {
- OM.addPredicate<ImmOperandMatcher>();
+ if (SrcChild.getOperator()->getName() == "bb") {
+ OM.addPredicate<MBBOperandMatcher>();
+ return Error::success();
+ }
+ if (SrcChild.getOperator()->getName() == "timm") {
+ OM.addPredicate<ImmOperandMatcher>();
- // Add predicates, if any
- for (const TreePredicateCall &Call : SrcChild.getPredicateCalls()) {
- const TreePredicateFn &Predicate = Call.Fn;
+ // Add predicates, if any
+ for (const TreePredicateCall &Call : SrcChild.getPredicateCalls()) {
+ const TreePredicateFn &Predicate = Call.Fn;
- // Only handle immediate patterns for now
- if (Predicate.isImmediatePattern()) {
- OM.addPredicate<OperandImmPredicateMatcher>(Predicate);
- }
+ // Only handle immediate patterns for now
+ if (Predicate.isImmediatePattern()) {
+ OM.addPredicate<OperandImmPredicateMatcher>(Predicate);
}
-
- return Error::success();
}
+
+ return Error::success();
}
} else if (auto *ChildDefInit = dyn_cast<DefInit>(SrcChild.getLeafValue())) {
auto *ChildRec = ChildDefInit->getDef();
@@ -1228,12 +1225,9 @@ Expected<action_iterator> GlobalISelEmitter::importExplicitUseRenderer(
// We accept 'bb' here. It's an operator because BasicBlockSDNode isn't
// inline, but in MI it's just another operand.
- if (Dst.getOperator()->isSubClassOf("SDNode")) {
- auto &ChildSDNI = CGP.getSDNodeInfo(Dst.getOperator());
- if (ChildSDNI.getSDClassName() == "BasicBlockSDNode") {
- DstMIBuilder.addRenderer<CopyRenderer>(Dst.getName());
- return InsertPt;
- }
+ if (Dst.getOperator()->getName() == "bb") {
+ DstMIBuilder.addRenderer<CopyRenderer>(Dst.getName());
+ return InsertPt;
}
// Similarly, imm is an operator in TreePatternNode's view but must be
More information about the llvm-commits
mailing list